Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2229] Support pulsar anthentication in Manager and Sort #2249

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented Jan 20, 2022

Title Name: [INLONG-XYZ][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #2229

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #2249 (266a984) into master (f340ce5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2249      +/-   ##
============================================
- Coverage     12.56%   12.54%   -0.02%     
- Complexity     1210     1219       +9     
============================================
  Files           417      420       +3     
  Lines         35914    36208     +294     
  Branches       5635     5674      +39     
============================================
+ Hits           4512     4543      +31     
- Misses        30599    30859     +260     
- Partials        803      806       +3     
Impacted Files Coverage Δ
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (-1.12%) ⬇️
...emq/server/common/paramcheck/PBParameterUtils.java 25.11% <0.00%> (-0.63%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.07% <0.00%> (-0.45%) ⬇️
...apache/inlong/tubemq/server/broker/TubeBroker.java 0.00% <0.00%> (ø)
...ache/inlong/tubemq/server/broker/BrokerConfig.java 0.00% <0.00%> (ø)
...long/tubemq/server/broker/BrokerServiceServer.java 0.00% <0.00%> (ø)
...emq/server/broker/offset/DefaultOffsetManager.java 0.00% <0.00%> (ø)
...mq/server/broker/msgstore/MessageStoreManager.java 0.00% <0.00%> (ø)
.../tubemq/server/broker/offset/OffsetRecordInfo.java 0.00% <0.00%> (ø)
...inlong/tubemq/server/broker/offset/RecordItem.java 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f340ce5...266a984. Read the comment docs.

Copy link
Contributor

@baomingyu baomingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@healchow healchow merged commit 7188718 into apache:master Jan 21, 2022
@dockerzhang dockerzhang added this to the 0.13.0 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Manager support pulsar authentification
5 participants