Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2274][Manager] Supports configuring whether to create a Hive database or table #2277

Merged
merged 3 commits into from
Jan 23, 2022

Conversation

healchow
Copy link
Member

Title Name: [INLONG-2274][Manager] Supports configuring whether to create a Hive database or table

Fixes #2274

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • DataStreamServiceTest.java
  • DataStorageServiceTest.java

Documentation

  • Does this pull request introduces a new feature? no

@dockerzhang dockerzhang added this to the 0.13.0 milestone Jan 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2277 (60031e9) into master (57cf8a7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2277      +/-   ##
============================================
+ Coverage     12.52%   12.54%   +0.01%     
- Complexity     1215     1218       +3     
============================================
  Files           420      420              
  Lines         36208    36235      +27     
  Branches       5674     5674              
============================================
+ Hits           4536     4546      +10     
- Misses        30865    30881      +16     
- Partials        807      808       +1     
Impacted Files Coverage Δ
...emq/server/common/paramcheck/PBParameterUtils.java 24.20% <0.00%> (-0.92%) ⬇️
...long/tubemq/server/broker/BrokerServiceServer.java 0.00% <0.00%> (ø)
...g/tubemq/server/broker/web/BrokerAdminServlet.java 0.00% <0.00%> (ø)
...bemq/server/master/metamanage/MetaDataManager.java 0.00% <0.00%> (ø)
...q/client/consumer/SimpleClientBalanceConsumer.java 0.00% <0.00%> (ø)
...rver/master/web/handler/WebTopicDeployHandler.java 0.00% <0.00%> (ø)
...ong/tubemq/server/common/fielddef/WebFieldDef.java 96.35% <0.00%> (+0.05%) ⬆️
...ng/tubemq/corebase/utils/DateTimeConvertUtils.java 92.50% <0.00%> (+0.39%) ⬆️
.../tubemq/server/common/utils/WebParameterUtils.java 18.65% <0.00%> (+0.70%) ⬆️
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.70% <0.00%> (+1.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cf8a7...60031e9. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit dbb2f94 into apache:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Supports configuring whether to create a Hive database or table
4 participants