Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2353] Tube manager cluster adds support for multi-master configuration #2360

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

bluewang
Copy link
Contributor

@bluewang bluewang commented Jan 27, 2022

Title Name: [INLONG-XYZ][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #2353

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #2360 (3899f02) into master (6bc4b37) will increase coverage by 0.00%.
The diff coverage is 41.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2360   +/-   ##
=========================================
  Coverage     12.54%   12.55%           
- Complexity     1219     1221    +2     
=========================================
  Files           420      420           
  Lines         36240    36255   +15     
  Branches       5670     5674    +4     
=========================================
+ Hits           4548     4551    +3     
- Misses        30884    30895   +11     
- Partials        808      809    +1     
Impacted Files Coverage Δ
...inlong/tubemq/manager/controller/TubeMQResult.java 60.00% <0.00%> (-3.16%) ⬇️
...long/tubemq/manager/service/MasterServiceImpl.java 5.79% <0.00%> (-0.87%) ⬇️
...ager/controller/cluster/request/AddClusterReq.java 75.00% <50.00%> (ø)
.../manager/controller/cluster/ClusterController.java 26.08% <60.00%> (+5.15%) ⬆️
...ong/tubemq/manager/service/ClusterServiceImpl.java 55.55% <100.00%> (+2.61%) ⬆️
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (-1.12%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.07% <0.00%> (-0.45%) ⬇️
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.70% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc4b37...3899f02. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang changed the title [INLONG-2353] Tube manager cluster adds support for multi-master conf… [INLONG-2353] Tube manager cluster adds support for multi-master configuration Feb 9, 2022
@dockerzhang dockerzhang added this to the 1.1.0 milestone Feb 9, 2022
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 98a2753 into apache:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][TubeMQ] Support multi-master configuration for tube-manager
5 participants