Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2373] Refactor of CreateBusinessWorkflow #2374

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented Jan 28, 2022

Title Name: [INLONG-XYZ][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #2373

Motivation

BusinessWorkflowProcess is difficult to expand

Modifications

refactoring the process of createBusinessWorkflow, make it more abstract and concise

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

kipshi added 3 commits January 26, 2022 10:22
# Conflicts:
#	inlong-manager/manager-service/src/test/resources/application-test.properties
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #2374 (4bb8771) into master (6bc4b37) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2374      +/-   ##
============================================
- Coverage     12.54%   12.52%   -0.03%     
+ Complexity     1219     1214       -5     
============================================
  Files           420      420              
  Lines         36240    36240              
  Branches       5670     5670              
============================================
- Hits           4548     4540       -8     
- Misses        30884    30893       +9     
+ Partials        808      807       -1     
Impacted Files Coverage Δ
...inlong/tubemq/manager/service/TaskServiceImpl.java 3.65% <0.00%> (-4.88%) ⬇️
...ong/tubemq/manager/service/ClusterServiceImpl.java 50.00% <0.00%> (-2.95%) ⬇️
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (-1.12%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.07% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc4b37...4bb8771. Read the comment docs.

Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang added this to the 0.13.0 milestone Jan 28, 2022
@dockerzhang dockerzhang merged commit 5d2e4e6 into apache:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Refactor of CreateBusinessWorkflow
4 participants