-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INlONG-2791][Manager] Optimize manager client APIs #2792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
only modify StreamSinkServiceImpl public PageInfo<? extends SinkListResponse> listByCondition(SinkPageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list sink page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sinkType = request.getSinkType();
Preconditions.checkNotNull(sinkType, Constant.SINK_TYPE_IS_EMPTY); StreamSourceServiceImpl public PageInfo<? extends SourceListResponse> listByCondition(SourcePageRequest request) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("begin to list source page by " + request);
}
Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
String sourceType = request.getSourceType();
Preconditions.checkNotNull(sourceType, Constant.SOURCE_TYPE_IS_EMPTY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
Title Name: [INlONG-2791] Optimize Inlong manager client apis
where XYZ should be replaced by the actual issue number.
Fixes #2791
Motivation
optimize methods in client
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation