Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INlONG-2791][Manager] Optimize manager client APIs #2792

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented Feb 28, 2022

Title Name: [INlONG-2791] Optimize Inlong manager client apis

where XYZ should be replaced by the actual issue number.

Fixes #2791

Motivation

optimize methods in client

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@healchow healchow added this to the 1.1.0 milestone Feb 28, 2022
@dockerzhang dockerzhang changed the title [INlONG-2791] Optimize Inlong manager client apis [INlONG-2791][manager] Optimize Inlong manager client apis Mar 1, 2022
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow changed the title [INlONG-2791][manager] Optimize Inlong manager client apis [INlONG-2791][Manager] Optimize manager client APIs Mar 1, 2022
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gong
Copy link
Contributor

gong commented Mar 1, 2022

only modify SinkPageRequest and SourcePageRequest will cause some problem.

StreamSinkServiceImpl

    public PageInfo<? extends SinkListResponse> listByCondition(SinkPageRequest request) {
        if (LOGGER.isDebugEnabled()) {
            LOGGER.debug("begin to list sink page by " + request);
        }
        Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
        String sinkType = request.getSinkType();
        Preconditions.checkNotNull(sinkType, Constant.SINK_TYPE_IS_EMPTY);

StreamSourceServiceImpl

    public PageInfo<? extends SourceListResponse> listByCondition(SourcePageRequest request) {
        if (LOGGER.isDebugEnabled()) {
            LOGGER.debug("begin to list source page by " + request);
        }
        Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
        String sourceType = request.getSourceType();
        Preconditions.checkNotNull(sourceType, Constant.SOURCE_TYPE_IS_EMPTY);

Copy link
Contributor

@ciscozhou ciscozhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@healchow healchow merged commit 76b8b30 into apache:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Optimize manager client APIs
5 participants