Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5428][Agent] Abstract metrics interface to be easier to extend #5430

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

pocozh
Copy link
Contributor

@pocozh pocozh commented Aug 9, 2022

Prepare a Pull Request

(Change the title refer to the following example)

  • [INLONG-5428][Agent] Abstract metrics interface to be easier to extend

(The following XYZ should be replaced by the actual GitHub Issue number)

Modifications

  • using metric template in inlong-common
  • modify metric config in agent.properties
  • support different metric listeners at the same time
  • remove unused classes

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit e62e5ad into apache:master Aug 10, 2022
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Abstract metrics interface to be easier to extend
5 participants