Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5476][Manager] Fix heartbeat status and node list query problem #5477

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

woofyzhao
Copy link
Contributor

@woofyzhao woofyzhao commented Aug 11, 2022

  1. the cache remove cause should be filtered
  2. should use cleanup to do eager eviction in time
    https://github.com/ben-manes/caffeine/wiki/Cleanup

image

This is exactly the case of heartbeat scenario
  1. Query by clusterTag is broken, fix it

@woofyzhao woofyzhao changed the title [INLONG-5476][Manager] Fix heartbeat status problem [INLONG-5476][Manager] Fix heartbeat status and node list query problem Aug 11, 2022
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit e8881da into apache:master Aug 12, 2022
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
…em (apache#5477)

Co-authored-by: woofyzhao <woofyzhao@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Manager] Heartbeat is not functioning properly under sparse report
4 participants