Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5599][Sort] Add temporal join support for MySQL #5600

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

yunqingmoswu
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

Title: [INLONG-5599][Sort] Add temporal join support for mysql

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #5599

Motivation

Add temporal join support for mysql.

Modifications

1.Add ExtractMode used to distinguish between different extract modes.
2.Update MySqlExtractNode to support scan.
3.Add unit test for this case.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title [INLONG-5599][Sort] Add temporal join support for mysql [INLONG-5599][Sort] Add temporal join support for MySQL Aug 19, 2022
@dockerzhang dockerzhang merged commit 5cfd05b into apache:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Add temporal join support for mysql
7 participants