[INLONG-6086][Manager] Support updating and deleting stream sink by key #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healchow
requested changes
Oct 8, 2022
...g-manager/manager-common/src/main/java/org/apache/inlong/manager/common/consts/SinkType.java
Outdated
Show resolved
Hide resolved
vernedeng
changed the title
healchow
reviewed
Oct 8, 2022
...manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/custom/CustomSinkRequest.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Oct 8, 2022
...manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/custom/CustomSinkRequest.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Oct 8, 2022
...ager-service/src/test/java/org/apache/inlong/manager/service/sink/CustomSinkServiceTest.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Oct 8, 2022
...manager-web/src/main/java/org/apache/inlong/manager/web/controller/StreamSinkController.java
Outdated
Show resolved
Hide resolved
vernedeng
force-pushed
the
INLONG-6086
branch
from
1d05255
to
dccbfbb
Compare
vernedeng
changed the title
healchow
changed the title
vernedeng
force-pushed
the
INLONG-6086
branch
from
7cce39c
to
c73d5a6
Compare
gosonzhang
approved these changes
Oct 14, 2022
healchow
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
support base stream sink operator
support delete stream sink by related id
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation