Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-6765][Sort] Supports dirty data side-output for Iceberg sink #6766

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

yunqingmoswu
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

  • Title: [INLONG-6765][Sort] Supports dirty data side-output for iceberg sink

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Supports dirty data side-output for iceberg sink.

In this part:

  1. Load 'DirtySinkFactory' and create 'DirtySink' by the config
  2. It needs to determine whether it is dirty data in the connector.
  3. Side output dirty data by the 'DirtySink' dependents on the configured, the built-in side-out of dirty data has 'LogDirtySink'([INLONG-6617][Sort] Add common process for dirty data sink and supports log sink #6618) and 'S3DirtySink'([INLONG-6654][Sort] Supports s3 side-output for dirty data #6655).

Modifications

  1. Create a dirty sink and inject it into Iceberg sink
  2. Add dirty handle for 'IcebergSingleStreamWriter' and 'DynamicSchemaHandleOperator'
  3. Add a unit test for this

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@yunqingmoswu yunqingmoswu added this to the 1.5.0 milestone Dec 6, 2022
@healchow healchow changed the title [INLONG-6765][Sort] Supports dirty data side-output for iceberg sink [INLONG-6765][Sort] Supports dirty data side-output for Iceberg sink Dec 6, 2022
@dockerzhang dockerzhang merged commit 08db5ea into apache:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Supports dirty data side-output for Iceberg sink
6 participants