Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-7903][Sort] Kafka sink supports fixed partition strategy #7905

Merged
merged 6 commits into from
May 10, 2023
Merged

[INLONG-7903][Sort] Kafka sink supports fixed partition strategy #7905

merged 6 commits into from
May 10, 2023

Conversation

lordcheng10
Copy link
Contributor

@lordcheng10 lordcheng10 commented Apr 24, 2023 •
edited
Loading

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Kafka sink supports fixed partition strategy.

Modifications

  1. Added InLongFixedPartitionPartitioner;
  2. In RawDataHashPartitioner, it is supported to specify the partition strategy according to the data source;

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@lordcheng10 lordcheng10 changed the title [[INLONG-7903][Sort] Kafka sink supports fixed partition strategy [INLONG-7903][Sort] Kafka sink supports fixed partition strategy Apr 24, 2023
EMsnap
EMsnap reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@EMsnap EMsnap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, could u please add some test for InLongFixedPartitionPartitioner?

@lordcheng10
Copy link
Contributor Author

Thanks for your contribution, could u please add some test for InLongFixedPartitionPartitioner?

I will add some tests.

@lordcheng10
Copy link
Contributor Author

Thanks for your contribution, could u please add some test for InLongFixedPartitionPartitioner?

I will add some tests.

@EMsnap fixed,PTAL,thanks!

@lordcheng10 lordcheng10 requested review from gong and EMsnap May 9, 2023 03:49
EMsnap
EMsnap approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@EMsnap EMsnap merged commit 39ec798 into apache:master May 10, 2023
aloyszhang
aloyszhang reviewed May 10, 2023
View reviewed changes
.../test/java/org/apache/inlong/sort/kafka/partitioner/InLongFixedPartitionPartitionerTest.java
* limitations under the License.
*/

package org.apache.inlong.sort.kafka.partitioner;/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated license

dockerzhang pushed a commit that referenced this pull request May 11, 2023
@lordcheng10 @dockerzhang
[INLONG-7903][Sort] Kafka sink supports fixed partition strategy (#7905)
81a23ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloyszhang aloyszhang aloyszhang left review comments

@yunqingmoswu yunqingmoswu yunqingmoswu approved these changes

@EMsnap EMsnap EMsnap approved these changes

@gong gong gong approved these changes

Assignees
No one assigned
Labels
component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Kafka sink supports fixed partition strategy
5 participants
@lordcheng10 @gong @EMsnap @yunqingmoswu @aloyszhang