Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-7993][Sort] Kafka connector should support group offset #7995

Closed
wants to merge 1 commit into from

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented May 10, 2023

Motivation

Modifications

add group offset in kafka connector

Verifying this change

when enable group offset, the startUpmode should be "group-offsets", and group id must be set

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@EMsnap EMsnap marked this pull request as draft May 10, 2023 07:30
@EMsnap
Copy link
Contributor Author

EMsnap commented May 11, 2023

fixed in #7997

@EMsnap EMsnap closed this May 11, 2023
@EMsnap EMsnap deleted the 7993 branch May 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Kafka connector should support group offset
1 participant