Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-8019][DataProxy] Optimize the function of getTopic() #8020

Merged
merged 2 commits into from
May 12, 2023
Merged

[INLONG-8019][DataProxy] Optimize the function of getTopic() #8020

merged 2 commits into from
May 12, 2023

Conversation

gosonzhang
Copy link
Contributor

@gosonzhang gosonzhang commented May 12, 2023 •
edited
Loading

  1. Remove the duplicate getTopic() function implementation, and place getTopicName() in the ConfigManager class, and remove the irrelevant getTopicProperties();
  2. Add pre-condition checks to http message processing

@dockerzhang
Copy link
Contributor

@gosonzhang please add more details for this PR.

@gosonzhang
Copy link
Contributor Author

@dockerzhang, thanks,done

luchunliang
luchunliang approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baomingyu
baomingyu approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@baomingyu baomingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gosonzhang gosonzhang merged commit f000b2d into apache:master May 12, 2023
@gosonzhang gosonzhang deleted the INLONG-8019 branch May 12, 2023 10:46
dockerzhang pushed a commit that referenced this pull request May 15, 2023
@gosonzhang @dockerzhang
[INLONG-8019][DataProxy] Optimize the function of getTopic() (#8020)
d58058d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luchunliang luchunliang luchunliang approved these changes

@baomingyu baomingyu baomingyu approved these changes

Assignees
No one assigned
Labels
component/dataproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][DataProxy] Optimize the function of getTopic()
4 participants
@gosonzhang @dockerzhang @baomingyu @luchunliang