-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAL Compression enhancement #12763
Merged
Merged
WAL Compression enhancement #12763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OneSizeFitsQuorum
commented
Jun 19, 2024
- enbale wal compression default
- enhance some codes and comments
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
from
June 19, 2024 06:14
06d3dba
to
492ded2
Compare
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
from
June 19, 2024 06:18
492ded2
to
fef03fb
Compare
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12763 +/- ##
============================================
+ Coverage 41.73% 41.74% +0.01%
Complexity 71 71
============================================
Files 3313 3314 +1
Lines 209459 209483 +24
Branches 24899 24906 +7
============================================
+ Hits 87425 87458 +33
+ Misses 122034 122025 -9 ☔ View full report in Codecov by Sentry. |
…n string Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
from
June 20, 2024 15:47
8adf994
to
60fd0d0
Compare
jt2594838
approved these changes
Jun 21, 2024
...re/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/LogWriter.java
Outdated
Show resolved
Hide resolved
...re/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/LogWriter.java
Outdated
Show resolved
Hide resolved
...tanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/WALFileVersion.java
Outdated
Show resolved
Hide resolved
...tanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/WALInputStream.java
Show resolved
Hide resolved
...tanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/WALInputStream.java
Outdated
Show resolved
Hide resolved
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
from
June 27, 2024 01:44
4e82f3c
to
d873f2a
Compare
HTHou
reviewed
Jun 27, 2024
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
3 times, most recently
from
June 27, 2024 15:49
747b7dc
to
4cf9617
Compare
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
from
June 27, 2024 15:52
4cf9617
to
b8c8834
Compare
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
OneSizeFitsQuorum
force-pushed
the
wal_compression
branch
from
June 27, 2024 15:57
4070095
to
f6aba54
Compare
Quality Gate failedFailed conditions |
JackieTien97
pushed a commit
that referenced
this pull request
Jul 10, 2024
* enhance Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * fix huge write Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * fix bug when recovering old version of wal * optimize the code * fix bug Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * fix testFileWithoutMagicString & make unknown version records v2 magin string Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * fix review issue Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * enhance version judgement Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * remove direct buffer Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * enhance test Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> * fix bug Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> --------- Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> Co-authored-by: Liu Xuxin <liuxuxin@outlook.com> (cherry picked from commit 709d714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.