Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL Compression enhancement #12763

Merged
merged 12 commits into from
Jun 28, 2024
Merged

WAL Compression enhancement #12763

merged 12 commits into from
Jun 28, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

  1. enbale wal compression default
  2. enhance some codes and comments

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 86.17886% with 17 lines in your changes missing coverage. Please review.

Project coverage is 41.74%. Comparing base (a460acb) to head (f6aba54).

Files Patch % Lines
...torageengine/dataregion/wal/io/WALInputStream.java 82.35% 9 Missing ⚠️
...ngine/dataregion/wal/recover/WALRecoverWriter.java 72.72% 3 Missing ⚠️
...torageengine/dataregion/wal/io/WALFileVersion.java 89.47% 2 Missing ⚠️
.../db/storageengine/dataregion/wal/io/WALWriter.java 87.50% 2 Missing ⚠️
.../db/storageengine/dataregion/wal/io/LogWriter.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12763      +/-   ##
============================================
+ Coverage     41.73%   41.74%   +0.01%     
  Complexity       71       71              
============================================
  Files          3313     3314       +1     
  Lines        209459   209483      +24     
  Branches      24899    24906       +7     
============================================
+ Hits          87425    87458      +33     
+ Misses       122034   122025       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

THUMarkLau and others added 4 commits June 19, 2024 17:11
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
…n string

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum OneSizeFitsQuorum force-pushed the wal_compression branch 3 times, most recently from 747b7dc to 4cf9617 Compare June 27, 2024 15:49
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 709d714 into master Jun 28, 2024
40 of 41 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the wal_compression branch June 28, 2024 03:01
JackieTien97 pushed a commit that referenced this pull request Jul 10, 2024
* enhance

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* fix huge write

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* fix bug when recovering old version of wal

* optimize the code

* fix bug

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* fix testFileWithoutMagicString & make unknown version records v2 magin string

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* fix review issue

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* enhance version judgement

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* remove direct buffer

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* enhance test

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* fix bug

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

---------

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Co-authored-by: Liu Xuxin <liuxuxin@outlook.com>
(cherry picked from commit 709d714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants