[IOTDB-872] Use system timezone in CLI (Session) #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
liutaohua
reviewed
Oct 26, 2020
| } | ||
| RpcUtils.verifySuccess(resp.getStatus()); | ||
| return resp.getTimeZone(); | ||
| return ZoneId.systemDefault().getId(); |
There was a problem hiding this comment.
There is something wrong with the logic.
It should be the default value that the server stores when the client is not registered with the server.
| } | ||
|
|
||
| private synchronized void setTimeZone(String zoneId) | ||
| public synchronized void setTimeZone(String zoneId) | ||
| throws StatementExecutionException, IoTDBConnectionException { | ||
| TSSetTimeZoneReq req = new TSSetTimeZoneReq(sessionId, zoneId); | ||
| TSStatus resp; |
There was a problem hiding this comment.
There may be a bug here, because the value stored by the server does not necessarily change when an error is encountered, but the local cached zoneId does
HTHou
reviewed
Oct 27, 2020
session/src/test/java/org/apache/iotdb/session/pool/SessionPoolTest.java
Show resolved
Hide resolved
HTHou
reviewed
Oct 27, 2020
|
Consider add some setting timezone tests in |
Added~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default timezone in server side.
Using the system default time zone of each client to decide the time zone of server operation.