[IOTDB-1163]optimize the insertRecords session interface for cluster version #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuyilan
changed the title
neuyilan
requested review from
jt2594838,
OneSizeFitsQuorum,
qiaojialin and
mychaow
and removed request for
OneSizeFitsQuorum
mychaow
approved these changes
Feb 20, 2021
| plan.getResults().put(i, RpcUtils.getStatus(e.getErrorCode(), e.getMessage())); | ||
| allSuccess = false; | ||
| } | ||
| if (!allSuccess) { |
There was a problem hiding this comment.
do we need to insert the left records while one record is failed? @qiaojialin
There was a problem hiding this comment.
Thanks for your review, in my opinion, I support inserting the remaining records in case of one record insertion failure. After all, we support partial insertion success. Moreover, this implementation is consistent with the previous semantics of composing each record into an InsertRowPlan.
|
SonarCloud Quality Gate failed. |
mychaow
approved these changes
Feb 23, 2021
| Map<Integer, TSStatus> checkTsStatus, | ||
| int totalRowCount) { | ||
|
|
||
| if (allSuccess) { |
There was a problem hiding this comment.
Changing allSuccess to allCheckSuccess is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IOTDB-1163