Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-2258] restructure the csv import tool #4954

Merged
merged 11 commits into from
Jan 29, 2022
Merged

[IOTDB-2258] restructure the csv import tool #4954

merged 11 commits into from
Jan 29, 2022

Conversation

xuanronaldo
Copy link
Contributor

@xuanronaldo xuanronaldo commented Jan 21, 2022

  1. using the insertAlignedRecords interface if the data is aligned by time.
  2. the memory limit of the CSV import tool is lifted.

@coveralls
Copy link

coveralls commented Jan 21, 2022

Coverage Status

Coverage increased (+0.02%) to 67.75% when pulling 5a7c6ea on xuanronaldo:restruct_csv_import_tool into 4e87d43 on apache:master.

Copy link
Contributor

@SilverNarcissus SilverNarcissus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Only two small issues, please have a look~

});
writeAndEmptyDataSet(device, times, typesList, valuesList, measurementsList, 3);
});
final int BATCH_SIZE = 10000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put this constant to class static level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got this.

@@ -61,7 +61,6 @@
"````````````````````````````````````````````````",
"Starting IoTDB Client Import Script",
"````````````````````````````````````````````````",
"Start to import data from: test.csv",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have made it back.

@qiaojialin qiaojialin merged commit 18dea61 into apache:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants