-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-2258] restructure the csv import tool #4954
[IOTDB-2258] restructure the csv import tool #4954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Only two small issues, please have a look~
}); | ||
writeAndEmptyDataSet(device, times, typesList, valuesList, measurementsList, 3); | ||
}); | ||
final int BATCH_SIZE = 10000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can put this constant to class static level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, got this.
@@ -61,7 +61,6 @@ | |||
"````````````````````````````````````````````````", | |||
"Starting IoTDB Client Import Script", | |||
"````````````````````````````````````````````````", | |||
"Start to import data from: test.csv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have made it back.
…t_csv_import_tool
insertAlignedRecords
interface if the data is aligned by time.