[IOTDB-2995]SchemaFileSketcher will not delete empty .pst now #5653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosZyk
approved these changes
Apr 25, 2022
xinzhongtianxia
pushed a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Apr 27, 2022
* remotes/upstream/master: [IOTDB-3005] Increase read and write permissions in ConfigExecution (apache#5664) [IOTDB-3007] Separate DataNode and IoTDB (apache#5668) [IOTDB-2968] RatisConsensus snapshot implementation (apache#5623) [IOTDB-2958]create a simple schemaCache for datanode metadata (apache#5602) [IOTDB-2912] MPP: FilterOperator (apache#5645) fix the issue that FragmentInstance's status cannot be updated to FINISHED in some scenario (apache#5660) Support set storage group in standalone mpp mode (apache#5655) Optimize source handle error handling (apache#5659) [IOTDB-2999][Metric] remove useless config and fix default value error. (apache#5657) [IOTDB-2966]fix CompactionTaskManagerTest CI (apache#5610) Fix schema file with cache of size 1 (apache#5651) will not delete empty .pst now (apache#5653) # Conflicts: # server/src/main/java/org/apache/iotdb/db/mpp/sql/analyze/Analyzer.java # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/LogicalPlanner.java # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/PlanNodeType.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, SchemaFileSketcher will delete an empty .pst file since it is useless. Then we found it is confusing for users, so now it will leave the empty file as it was.