Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-8892: Add javadoc to package-info files #175

Closed
wants to merge 3 commits into from

Conversation

averma21
Copy link
Member

@averma21 averma21 commented Feb 3, 2020

No description provided.

*/

/**
* This package contains tokenization related classes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe "FV" stands for "feature vector", and I think that should be added in the package documentation. And probably a link to https://en.wikipedia.org/wiki/Feature_(machine_learning). The documentation about this in Oak is here: http://jackrabbit.apache.org/oak/docs/query/lucene.html#similar-fv - maybe you want to read this as well and update the Javadocs a bit.

*/

/**
* This package contains index creation and editing related classes and interfaces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"editing related" is not the right term I think... The word "edit" comes from the oak "Editor", which is the mechanism used to observe changes (like a "trigger" in a relational database).

I would write something like "Contains classes that deal with updating indexes, including how to build indexing backend documents (e.g. Lucene documents)".

amrverma added 2 commits February 5, 2020 15:06
* updating as per review comments
* Adding one more package-info file
@github-actions
Copy link

This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 23, 2022
@github-actions github-actions bot closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants