Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAMES-3942 Audit user trail #1738

Merged
merged 23 commits into from
Oct 6, 2023
Merged

JAMES-3942 Audit user trail #1738

merged 23 commits into from
Oct 6, 2023

Conversation

quantranhong1999
Copy link
Contributor

resolve linagora#4866

@quantranhong1999 quantranhong1999 mentioned this pull request Sep 25, 2023
Closed
20 tasks
chibenwa
chibenwa reviewed Sep 25, 2023
View reviewed changes
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/LocalDelivery.java Outdated Show resolved Hide resolved
...er/data/data-file/src/main/java/org/apache/james/mailrepository/file/FileMailRepository.java Outdated Show resolved Hide resolved
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java Outdated Show resolved Hide resolved
...repository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepository.scala Outdated Show resolved Hide resolved
...ssandra/src/main/java/org/apache/james/mailrepository/cassandra/CassandraMailRepository.java Outdated Show resolved Hide resolved
...sitory-memory/src/main/java/org/apache/james/mailrepository/memory/MemoryMailRepository.java Outdated Show resolved Hide resolved
server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SendMailHandler.java Outdated Show resolved Hide resolved
Arsnael
Arsnael reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it nothing to add

@quantranhong1999 quantranhong1999 marked this pull request as ready for review September 28, 2023 10:40
@Arsnael
Copy link
Contributor

Arsnael commented Sep 29, 2023

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1738/5/

Related or not? I find that weird :o

@quantranhong1999
Copy link
Contributor Author

Related or not?

Likely related.

@Arsnael
Copy link
Contributor

Arsnael commented Oct 2, 2023

Green build.

Can you squash your fixups @quantranhong1999 ?

@quantranhong1999
Copy link
Contributor Author

Can you squash your fixups @quantranhong1999 ?

I am fixing some remaining review comments. Please wait ^^.

vttranlina
vttranlina reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@vttranlina vttranlina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of "Lazy evaluation" in this case?

.protocol(() -> "IMAP")
.action(() -> "AUTH")

It looks quite verbose

@quantranhong1999
Copy link
Contributor Author

It looks quite verbose

Likely could just be eager there.

@Arsnael
Copy link
Contributor

Arsnael commented Oct 4, 2023

The second time in a row I see this error in the builds here: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1738/10/testReport/org.apache.james.jmap.memory.upload/InMemoryUploadServiceTest/givenQuotaExceededThenUploadShouldRepairInconsistentCurrentUsage/

I don't believe audit trail is the reason but can you double check please? But maybe more like a flaky test to me

@quantranhong1999
Copy link
Contributor Author

But maybe more like a flaky test to me

Yes, it is. I would prefer to investigate that flaky test later.

@Arsnael
Copy link
Contributor

Arsnael commented Oct 4, 2023

Same again... can you try adding #1748 to see? Getting desperate here :)

@quantranhong1999
JAMES-3942 Audit trail upon RemoteDelivery planned
eb45dee
@quantranhong1999
JAMES-3942 Fix review comments
72bb551
@quantranhong1999
JAMES-3942 Audit trail upon RemoteDelivery success
fc362e1
@quantranhong1999
JAMES-3942 Audit trail upon RemoteDelivery failure
1d99e1a
@quantranhong1999
JAMES-3942 Audit trail upon JMAP email sent
f13d6d9
@quantranhong1999
JAMES-3942 Audit trail upon JMAP delegation changes
f2ad123
@quantranhong1999
JAMES-3942 Audit trail better handle null input parameters
7f98b6e
@quantranhong1999
JAMES-3942 Audit trail upon IMAP authentication success
53893b6
@quantranhong1999
JAMES-3942 Audit trail upon IMAP authentication failure
9509eb1
@quantranhong1999
JAMES-3942 Audit trail upon IMAP expunge success
dd29855
@quantranhong1999
JAMES-3942 Audit trail upon Email/set destroy
3a75ab0
@quantranhong1999
JAMES-3942 Audit trail upon JMAP email full view read
46f3550
@quantranhong1999
JAMES-3942 Audit trail upon IMAP email full read
ae3c73d
@quantranhong1999
JAMES-3942 Audit trail upon JMAP rights sharing changed
2a4ee58
@quantranhong1999
JAMES-3942 Audit trail upon LMTP email sent
2d77e36
@quantranhong1999
JAMES-3942 Lazy evaluation for AuditTrail + AuditTrail failure should…
dfcc867 
… not fail protocol processing
@Arsnael Arsnael merged commit 7b45350 into apache:master Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa approved these changes

@Arsnael Arsnael Arsnael approved these changes

@hungphan227 hungphan227 hungphan227 approved these changes

@vttranlina vttranlina vttranlina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@quantranhong1999 @Arsnael @chibenwa @hungphan227 @vttranlina