Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider #1804

Merged
merged 4 commits into from
Nov 22, 2023
Merged

JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider #1804

merged 4 commits into from
Nov 22, 2023

Conversation

vttranlina
Copy link
Contributor

@vttranlina vttranlina changed the title JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider @vttranlina [WIP] JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider @vttranlina Nov 21, 2023
@vttranlina vttranlina mentioned this pull request Nov 21, 2023
Closed
@vttranlina vttranlina changed the title [WIP] JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider @vttranlina [WIP] JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider Nov 21, 2023
@vttranlina
Copy link
Contributor Author

A lot of test classes depend on JPAMessageMapper, JPAMailboxMapper .
Special is JPAMessageMapper is using JPA MAILBOX for query some logic.
When I tried to "only" adapt postgres UidProvider, ModSeqProvider, I got a lot of failed tests. => The adapt for mapper will do in another pr

@vttranlina vttranlina changed the title [WIP] JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider JAMES-2586 Implement PostgresUidProvider, PostgresModSeqProvider Nov 21, 2023
@vttranlina vttranlina marked this pull request as ready for review November 21, 2023 10:36
chibenwa
chibenwa reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall +1 given that bindings for mailbox are done separatly...

vttranlina added a commit to vttranlina/james-project that referenced this pull request Nov 21, 2023
@vttranlina
[NO_REVIEW] apache#1804 JAMES-2586 Implement PostgresModSeqProvider, …
e6d29cb 
…PostgresUidProvider
@chibenwa chibenwa mentioned this pull request Nov 21, 2023
Closed
@vttranlina
Copy link
Contributor Author

rebase

@chibenwa chibenwa merged commit 666c7e1 into apache:postgresql Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa approved these changes

@Arsnael Arsnael Arsnael approved these changes

@hungphan227 hungphan227 hungphan227 approved these changes

@quantranhong1999 quantranhong1999 quantranhong1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vttranlina @chibenwa @Arsnael @hungphan227 @quantranhong1999