Synchronize ByteSourcePayload in LocalBlobStore #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is a narrower fix where |
|
If the LocalBlobStore can sync ina. narrower scope that would be much better |
ByteSourcePayload's.openStream is not thread safe and lack of synchronization can throw ArrayIndexOutOfBoundsExceptions. Fixes gaul/s3proxy#303.
gaul
force-pushed
the
synchronized-closer
branch
from
a473c70
to
dea756a
Compare
gaul
changed the title
Done. |
|
Something seems strange here -- every call to |
nacx
approved these changes
Jul 31, 2022
|
Superseded by #150. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteSourcePayload's.openStreamis not thread safe and lack ofsynchronization can throw
ArrayIndexOutOfBoundsExceptions.Fixes gaul/s3proxy#303.