Fix ContextBuilder bug when using credentials supplier with azureblob #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure cloud providers specifically use an identity as part of their endpoint.
When attempting to use a ContextBuilder with the (new-ish?) credentialsSupplier option, we were seeing errors building an endpoint due to string interpolation failures, since the Azure module was not expecting a Supplier (rather, a specific
identity
andcredential
)This is not a comprehensive fix (any subsequent change to the identity will not be reflected in the endpoint going forward) but partially addresses a serious problem (unable to use ContextBuilder's
credentialsSupplier
for Azure providers)I plan on a more thorough change that will allow on-the-fly changes to an Azure provider's identity/credential, but this is more difficult. I believe I'll need to find every place where the endpoint is referenced and handle the case where a credentialsSupplier is being used (IOW, every place where the endpoint must be generated on the fly).
Any pointers or feedback about the above is appreciated!