-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENA-2273: Fix ASK in ResultSetWriterCSV and -TSV #1189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small problem - that code isn't being called.
There is a migration going on from ResultSet to RowSet as the basic for the machinery. RowSet works exclusively at the Node
level.
jena/jena-arq/src/main/java/org/apache/jena/riot/resultset/ResultSetReaderRegistry.java
Line 82 in d3fe7bb
if ( false ) { |
The registration of the ResultSet version is if/false'd out.
ResultSet
objects are now an adapter to the RowSet
version from package org.apache.jena.riot.rowset.rw
as of jena 4.4.0. The code looks very similar.
One style point (which ought to apply to the existing code) on try-finally.
Some tabs are used instead of spaces.
Github display means spaces work better across everyone's views.
jena-arq/src/main/java/org/apache/jena/riot/resultset/rw/ResultSetWriterCSV.java
Outdated
Show resolved
Hide resolved
jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TestResultSetWriterCSV.java
Outdated
Show resolved
Hide resolved
jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TestResultSetWriterTSV.java
Outdated
Show resolved
Hide resolved
As long as we're clear this is technically an extension to the standard! |
Both RowSetWriters had the same problems, and I added a commit that fixes them (and adds the same test classes). |
I've pulled PR and it all works, command line and in Fuseki but the build itself fails because of missing Apache License headers on new files. Sorry for not spotting this earlier.
It is the same header as a file you've modified. I'll leave it up to you whether you want to squash the PR to a single commit or not. |
I've added the license headers and squashed the commits. |
No description provided.