fix for custom builtins not being used when parsing rules #1268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule.rulesFromURL(String, BuiltinRegistry)
does not pass theBuiltinRegistry
argument toRule.rulesParserFromReader()
. This means that a user-specified builtin registry cannot be used with rules that are loaded usingrulesFromURL()
. This seems like a bug, so I can create a corresponding GitHub or JIRA issue, but wanted to first present this pull request. This is a simple one-line fix to passregistry
intorulesParserFromReader()
, along with some additional unit tests and a minor reorganization for some of the.rules
files.If you checkout just the
TestRuleLoader.java
unit test file from this PR, you can see that theload_from_file_with_custom_builtins()
test fails. After adding the change toRule.java
, the test passes.