JENA-2097: Bad URIs are parser warnings #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy. Add assertion in TestDatabaseOps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENA-2097 shows two things:
Only IRI syntax that is broken to the point where
<>can't be matched or impossible characters (e.g. space) are used should be a parse-stop error as it was in jena 3.17.0, especially for N-Triples.To this end, add a test suite
TestIRIxRIOTthat has test cases for all the situations, checking the numbers of errors and warning produced for the new IRIx abstraction use in RIOT parsing.Relative IRIs are now a special case with their own exception
RelativeIRIException. Some formats (N-Triples when not strict) accept them. Turtle always resolves them (and there is always a base) unless specific low-level setup is done when it can be a parse-stop error.Behaviour in normal use should be like 3.17.0 with only possible changes of ERROR to WARN in messages. Behaviour in detailed setup for Turtle now has test cases.