Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-use pattern when possible #216

Closed
wants to merge 1 commit into from
Closed

re-use pattern when possible #216

wants to merge 1 commit into from

Conversation

@benbenw
Copy link

@benbenw benbenw commented Jul 18, 2016

No description provided.

@@ -58,6 +61,6 @@ public String getMethod() {
public static boolean isWebdavMethod(String method) {
// A HTTP method can be a token as specified in
// https://tools.ietf.org/html/rfc7230#section-3.2.6

This comment has been minimized.

@sebbASF

sebbASF Jul 18, 2016
Contributor

Comment needs to be moved to where Pattern is defined

@@ -147,6 +148,8 @@
private static final int TIME_TO_LIVE = JMeterUtils.getPropDefault("httpclient4.time_to_live", 2000);

private static final String CONTEXT_METRICS = "jmeter_metrics"; // TODO hack for metrics related to HTTPCLIENT-1081, to be removed later

private static final Pattern PORT_PATTERN = Pattern.compile("^\\d+$");

This comment has been minimized.

@sebbASF

sebbASF Jul 18, 2016
Contributor

Does not need anchors

@@ -41,6 +42,8 @@
public class TimeFunction extends AbstractFunction {

private static final String KEY = "__time"; // $NON-NLS-1$

private static final Pattern FORMAT_PATTERN = Pattern.compile("/\\d+");

This comment has been minimized.

@sebbASF

sebbASF Jul 18, 2016
Contributor

Needs better name, e.g. DIVISOR_PATTERN

@asfgit asfgit closed this in 1c794a8 Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.