New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves JMS component robustness #240

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
4 participants
@max3163
Contributor

max3163 commented Dec 14, 2016

For both publisher and subcriber : improve error handling and allow to force reconnection against some error codes (using a new UI field and regular expression)

Only for subscriber, adds a wait between errors to avoid UI freeze due to infinite loops in case of repetitive errors.

PS : Some code relies on Java 8 (Predicate & lambda)

@loganmzz

This comment has been minimized.

Show comment
Hide comment
@loganmzz

loganmzz Dec 19, 2016

Here is a sample script to check robustness against an ActiveMQ instance.

JMeter-ActiveMQ.zip

Try to launch script with a started/stopped server, and stop/restart server during test to check sample results and JMeter behaviour.

loganmzz commented Dec 19, 2016

Here is a sample script to check robustness against an ActiveMQ instance.

JMeter-ActiveMQ.zip

Try to launch script with a started/stopped server, and stop/restart server during test to check sample results and JMeter behaviour.

@pmouawad

This comment has been minimized.

Show comment
Hide comment
@pmouawad

pmouawad Dec 28, 2016

Contributor

Thanks for contribution.
Few notes:

  • docs (component-reference.xml) should be updated
  • In handleError, I think you should surround close line 232 with try/catch
Contributor

pmouawad commented Dec 28, 2016

Thanks for contribution.
Few notes:

  • docs (component-reference.xml) should be updated
  • In handleError, I think you should surround close line 232 with try/catch
@loganmzz

This comment has been minimized.

Show comment
Hide comment
@loganmzz

loganmzz Dec 28, 2016

Close publisher isn't supposed to throw exception. A quick view at the code, confirms only system (in VM sense) error can be raised. What is supposed to be done in this case ?

loganmzz commented Dec 28, 2016

Close publisher isn't supposed to throw exception. A quick view at the code, confirms only system (in VM sense) error can be raised. What is supposed to be done in this case ?

@asfgit asfgit closed this in 188d412 Jan 14, 2017

@pmouawad

This comment has been minimized.

Show comment
Hide comment
@pmouawad

pmouawad Jan 14, 2017

Contributor

Hello,
Thanks for PR.
I have commited it but with some slight changes.
Could you test nightly build and give us feedback ?
Also could you attach the JMX plan that you attached to this PR as a zip (which I am not able to read) to the bugzilla 60585

Thank you

Contributor

pmouawad commented Jan 14, 2017

Hello,
Thanks for PR.
I have commited it but with some slight changes.
Could you test nightly build and give us feedback ?
Also could you attach the JMX plan that you attached to this PR as a zip (which I am not able to read) to the bugzilla 60585

Thank you

@max3163 max3163 deleted the max3163:POW-314 branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment