Parallelised unit tests #350
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #350 +/- ##
============================================
+ Coverage 58.28% 58.29% +0.01%
- Complexity 10217 10228 +11
============================================
Files 1160 1160
Lines 74426 74424 -2
Branches 7343 7362 +19
============================================
+ Hits 43378 43388 +10
+ Misses 28552 28535 -17
- Partials 2496 2501 +5
Continue to review full report at Codecov.
|
Introduced JMeterSerialTest interface for tests which need to be run individually in sequence not concurrently. Re-wrote TestFileServer in Spock to use private constructor to get around singleton. Also refactored/re-formatted some code while investigating parallel test failures.
Contributed by Graham Russell This closes #350 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1817425 13f79535-47bb-0310-9956-ffa450edef68
Contributed by Graham Russell This closes #350 svn:eol git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1817426 13f79535-47bb-0310-9956-ffa450edef68
Hi @ham1 , See https://travis-ci.org/apache/jmeter/jobs/313214205 I'll have a look this week-end but if you have an idea before, feel free to propose a PR. Regards |
Not sure. I can reproduce on trunk but It doesn't happen on this PR for me. Should have time at the weekend to investigate, |
Maybe this is the culprit: URL: http://svn.apache.org/viewvc?rev=1817421&view=rev |
If we initialize the string text to an empty string in the anonymous inner class, the tests pass. |
Description
introduced
JMeterSerialTest
interface for tests which need to be run in sequence not concurrently.Re-wrote
TestFileServer
in Spock to use private constructor to get around singleton and make clearer to understand.Added a test listener to time and log to file time taken for each unit test.
Also refactored/re-formatted some code while investigating parallel test failures.
ant _test
time on a 4 core laptop:before: 1m 19s
after: 51s
on an 8 core PC:
before: 59s
after: 31s
I'd welcome more testing on different configurations and review.
Motivation and Context
Speed up feedback
How Has This Been Tested?
100 iterations of
ant _test
on an 8 core machine50 iterations of
ant _test
on a 4 core machineScreenshots (if appropriate):
Types of changes
Checklist: