Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOHNZON-312 #63

Closed
wants to merge 1 commit into from
Closed

JOHNZON-312 #63

wants to merge 1 commit into from

Conversation

ART515
Copy link

@ART515 ART515 commented May 7, 2020

Fix for the JOHNZON-312 issue.

@rmannibucau
Copy link
Contributor

Hi @ART515 , jira is in maintenance so will leave the comment there: is the expected result you put where TUESDAY get start=null wrong for the patch? I think it should be MONDAY.start=null right?

In terms of patch I'm experiencing an alternative impl with a boolean/state propagated to say if the nested structure must be checked for patch or not, it is a bit faster than checking all strings since it just requires to check last string then the not matching subobjects should be a boolean check only.
Let me a few minutes to see if it works.

@rmannibucau
Copy link
Contributor

@ART515 pushed my proposed fix on master if you can review it it would be awesome. Happy to get feedbacks compared to your fix (we can revert/rework it, nothing is in the stone yet)

@rmannibucau
Copy link
Contributor

Is it stil needed?

@rmannibucau
Copy link
Contributor

up?

@jeanouii
Copy link
Contributor

Fixed so closing

@jeanouii jeanouii closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ART515 @rmannibucau @jeanouii