Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build reproducible #93

Merged
merged 1 commit into from
Nov 13, 2022
Merged

make build reproducible #93

merged 1 commit into from
Nov 13, 2022

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Oct 1, 2022

No description provided.

@SingingBush
Copy link
Contributor

@hboutemy could you rebase this on top of the recent changes in master along with also putting <maven.compiler.target>1.8</maven.compiler.target> into the properties of the main pom because the apache super pom set's it to 1.7

@rmannibucau please can this get merged, it'll help with my next PR

@hboutemy
Copy link
Member Author

@SingingBush rebase done
@rmannibucau ok to merge?

@rmannibucau
Copy link
Contributor

Ok for me, i cna handle the fact to keep a dynamic timestamp for snapshot after the merge so let's go

@hboutemy
Copy link
Member Author

I can handle the fact to keep a dynamic timestamp for snapshot after the merge

what does that mean?

@rmannibucau
Copy link
Contributor

Maybe to only set a build timestamp in release profile - maybe based on the version, didnt think of that last part.

@hboutemy
Copy link
Member Author

oh, you want a more complex setup: is there a concrete problem you're trying to solve?

if you really want to disable reproducible builds for SNAPSHOTs (for a reason I'd love to understand), you can create a profile and define a 1 char value: this will disable reproducible builds

@rmannibucau
Copy link
Contributor

It is more about having the real build timestamp in the jar than a meaningless value

@rmannibucau rmannibucau merged commit 514250a into apache:master Nov 13, 2022
@rmannibucau
Copy link
Contributor

Integrated, seems output does not have the pitfall I was thinking about cause project never set it up, thanks for the ready to use PR 👍

@SingingBush SingingBush mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants