This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
Owner Ids are maintained in separate mapping now #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen estimateCost(). Also refactored the code a little bit to have StateMinimizingLanguageModels support classes as well. Added some unit tests. The existing regression test output was changed to the new output.
…own mapping. Fixes a bug with multiple packed grammars that would overwrite each others owner Vocab id. Also cleaned up grammar constructors a little bit.
|
Great, this checks out for me. Since it contains the class LM fix, too, though, I'll wait to merge until those tests pass. |
|
Alright, I can rebase this PR once the ClassLM PR is merged so that we have a clean separation of those two commits on Github |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed owner ids from Vocabulary. These are now maintained in their own mapping. Fixes a bug with multiple packed grammars that would overwrite each others owner Vocab id. Also cleaned up grammar constructors a little bit.
The owner id is now strongly typed to prevent users to accidentally use ints that do not represent an actual OwnerId. Further OwnerIds can only be returned by the OwnerMap.register() method.
@mjpost I am obviously not a Github PR expert. This PR includes the other one about class LMs. Lets coordinate merging if you are ok with both.