JSPWIKI-1148 - Avoid File Stream #47
Conversation
| @@ -141,15 +142,15 @@ public static Properties loadWebAppProps( final ServletContext context ) { | |||
| * @return inputstream holding the properties file | |||
| * @throws FileNotFoundException properties file not found | |||
| */ | |||
| static InputStream loadCustomPropertiesFile( final ServletContext context, final String propertyFile ) throws FileNotFoundException { | |||
| static InputStream loadCustomPropertiesFile( final ServletContext context, final String propertyFile ) throws IOException { | |||
There was a problem hiding this comment.
@juanpablo-santos
Special careful here. Signature changed.
arturobernalg
force-pushed
the
feature/JSPWIKI-1148
branch
from
0f216fc
to
967b3a2
Compare
|
@juanpablo-santos ping here ;) |
|
Hi @arturobernalg , apologies for the long delay looking at this PR. I'm +1 on merging it, however, would you mind pls rebasing with latest commits? As for the signature change, that method is package-protected and seems to be used only by the best regards, |
arturobernalg
force-pushed
the
feature/JSPWIKI-1148
branch
from
967b3a2
to
5a20a0e
Compare
HI @juanpablo-santos , rebase from master. I think all the changes are already made previously. |
Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
Please note, that the java.nio API does not throw a FileNotFoundException anymore, instead it throws a NoSuchFileException.
https://github.com/apache/jspwiki/blob/master/jspwiki-util/src/main/java/org/apache/wiki/util/PropertyReader.java#L144