-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-7012: Don't process SSL channels without data to process #5237
KAFKA-7012: Don't process SSL channels without data to process #5237
Conversation
@radai-rosenblatt @junrao @ijuma Can you review please? Thank you! |
selector.poll(5); | ||
} | ||
|
||
// Verify that pollSelectionKeys was invoked at least once once to process buffered data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - "once once"
boolean isClosed = false; | ||
// Each loop reads at most once from the socket. | ||
while (dst.remaining() > 0) { | ||
int netread = 0; | ||
netReadBuffer = Utils.ensureCapacity(netReadBuffer, netReadBufferSize()); | ||
if (netReadBuffer.remaining() > 0) | ||
netread = readFromSocketChannel(); | ||
if (netread > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
performance nit - this if can be moved inside the previous if, for some infinitesimal performance gain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajinisivaram : Thanks for the patch. LGTM. Just a minor question below.
// Verify that pollSelectionKeys was invoked at least once once to process buffered data | ||
// but not more than once again since there isn't sufficient data to process. | ||
assertTrue("Buffered data not processed: " + node1Polls, node1Polls.get() >= 1); | ||
assertTrue("Too many calls to pollSelectionKeys: " + node1Polls, node1Polls.get() <= 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, why would node1 get polled a second time? It seems that after the first poll, it would notice that it's not making progress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just being over-cautious just in case. But you are right, it shouldn't get polled a second time. I have updated the test.
@radai-rosenblatt @junrao Thank you both for the reviews. I have made the updates. I will merge to trunk and 2.0 after builds complete. I also ran system tests yesterday and there weren't any failures in the tests using SSL (there were connect and compatibilty test failures, which are known issues). |
6dad19f
to
b697678
Compare
Test failure looks unrelated, merging to trunk and 2.0. |
Avoid unnecessary processing of SSL channels when there are some bytes buffered, but not enough to make progress. Reviewers: Radai Rosenblatt <radai.rosenblatt@gmail.com>, Jun Rao <junrao@gmail.com>
Avoid unnecessary processing of SSL channels when there are some bytes buffered, but not enough to make progress. Reviewers: Radai Rosenblatt <radai.rosenblatt@gmail.com>, Jun Rao <junrao@gmail.com>
Avoid unnecessary processing of SSL channels when there are some bytes buffered, but not enough to make progress. Reviewers: Radai Rosenblatt <radai.rosenblatt@gmail.com>, Jun Rao <junrao@gmail.com>
…e#5237) Avoid unnecessary processing of SSL channels when there are some bytes buffered, but not enough to make progress. Reviewers: Radai Rosenblatt <radai.rosenblatt@gmail.com>, Jun Rao <junrao@gmail.com>
…:1.1.1-sync to 1.1-nflx * commit '9611672e287c1a7933a78590e3f381da2ae7d136': (57 commits) MINOR: increase dev version from 1.1.1-SNAPSHOT to 1.1.2-SNAPSHOT (apache#5409) MINOR: Add thread dumps if broker node cannot be stopped (apache#5373) MINOR: update release.py MINOR: fix upgrade docs for Streams (apache#5392) MINOR: improve docs version numbers (apache#5372) Update version on the branch to 1.1.2-SNAPSHOT KAFKA-6292; Improve FileLogInputStream batch position checks to avoid type overflow (apache#4928) HOTFIX: Fix checkstyle errors in MetricsTest (apache#5345) KAFKA-7136: Avoid deadlocks in synchronized metrics reporters (apache#5341) MINOR: Close timing window in SimpleAclAuthorizer startup (apache#5318) MINOR: Use kill_java_processes when killing ConsoleConsumer in system tests (apache#5297) KAFKA-7104: More consistent leader's state in fetch response (apache#5305) Revert "MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258)" MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258) MINOR: bugfix streams total metrics (apache#5277) KAFKA-7082: Concurrent create topics may throw NodeExistsException (apache#5259) MINOR: Upgrade to Gradle 4.8.1 KAFKA-7012: Don't process SSL channels without data to process (apache#5237) KAFKA-7058: Comparing schema default values using Objects#deepEquals() KAFKA-7047: Added SimpleHeaderConverter to plugin isolation whitelist ...
Avoid unnecessary processing of SSL channels when there are some bytes buffered, but not enough to make progress.
Committer Checklist (excluded from commit message)