Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Close timing window in SimpleAclAuthorizer startup #5318

Merged
merged 1 commit into from
Jul 2, 2018
Merged

MINOR: Close timing window in SimpleAclAuthorizer startup #5318

merged 1 commit into from
Jul 2, 2018

Conversation

rajinisivaram
Copy link
Contributor

ZooKeeper listener for change notifications should be created before loading the ACL cache to avoid timing window if acls are modified when broker is starting up.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rajinisivaram rajinisivaram requested a review from junrao July 2, 2018 11:37
junrao
junrao approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajinisivaram : Thanks for the patch. LGTM

@ijuma
Copy link
Contributor

ijuma commented Jul 2, 2018

Seems like we should backport this.

@rajinisivaram
Copy link
Contributor Author

@junrao @ijuma Thanks for the review. Yes, I was thinking of cherry-picking to older branches, but wasn't planning to create another RC since it has always been this way and no one has run into an issue.

@rajinisivaram rajinisivaram merged commit 0db8074 into apache:trunk Jul 2, 2018
rajinisivaram added a commit that referenced this pull request Jul 2, 2018
@rajinisivaram
MINOR: Close timing window in SimpleAclAuthorizer startup (#5318)
bfe7e9a 
ZooKeeper listener for change notifications should be created before loading the ACL cache to avoid timing window if acls are modified when broker is starting up.

Reviewers: Jun Rao <junrao@gmail.com>, Ismael Juma <ismael@confluent.io>
rajinisivaram added a commit that referenced this pull request Jul 2, 2018
@rajinisivaram
MINOR: Close timing window in SimpleAclAuthorizer startup (#5318)
4102073 
ZooKeeper listener for change notifications should be created before loading the ACL cache to avoid timing window if acls are modified when broker is starting up.

Reviewers: Jun Rao <junrao@gmail.com>, Ismael Juma <ismael@confluent.io>
rajinisivaram added a commit that referenced this pull request Jul 2, 2018
@rajinisivaram
MINOR: Close timing window in SimpleAclAuthorizer startup (#5318)
36bb0ea 
ZooKeeper listener for change notifications should be created before loading the ACL cache to avoid timing window if acls are modified when broker is starting up.

Reviewers: Jun Rao <junrao@gmail.com>, Ismael Juma <ismael@confluent.io>
rajinisivaram added a commit that referenced this pull request Jul 2, 2018
@rajinisivaram
MINOR: Close timing window in SimpleAclAuthorizer startup (#5318)
ada1ab8 
ZooKeeper listener for change notifications should be created before loading the ACL cache to avoid timing window if acls are modified when broker is starting up.

Reviewers: Jun Rao <junrao@gmail.com>, Ismael Juma <ismael@confluent.io>
@rajinisivaram
Copy link
Contributor Author

Merged to trunk, 2.0, 1.1, 0.11.0 and 0.10.2 branches

ying-zheng pushed a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
@rajinisivaram @ying-zheng
MINOR: Close timing window in SimpleAclAuthorizer startup (apache#5318)
897c4af 
ZooKeeper listener for change notifications should be created before loading the ACL cache to avoid timing window if acls are modified when broker is starting up.

Reviewers: Jun Rao <junrao@gmail.com>, Ismael Juma <ismael@confluent.io>
allenxwang pushed a commit to allenxwang/kafka that referenced this pull request Aug 24, 2018
Merge pull request apache#77 in DATA_PIPELINE/kafka from ~AWANG/kafka…
8d3ddf2 
…:1.1.1-sync to 1.1-nflx

* commit '9611672e287c1a7933a78590e3f381da2ae7d136': (57 commits)
  MINOR: increase dev version from 1.1.1-SNAPSHOT to 1.1.2-SNAPSHOT (apache#5409)
  MINOR: Add thread dumps if broker node cannot be stopped (apache#5373)
  MINOR: update release.py
  MINOR: fix upgrade docs for Streams (apache#5392)
  MINOR: improve docs version numbers (apache#5372)
  Update version on the branch to 1.1.2-SNAPSHOT
  KAFKA-6292; Improve FileLogInputStream batch position checks to avoid type overflow (apache#4928)
  HOTFIX: Fix checkstyle errors in MetricsTest (apache#5345)
  KAFKA-7136: Avoid deadlocks in synchronized metrics reporters (apache#5341)
  MINOR: Close timing window in SimpleAclAuthorizer startup (apache#5318)
  MINOR: Use kill_java_processes when killing ConsoleConsumer in system tests (apache#5297)
  KAFKA-7104: More consistent leader's state in fetch response (apache#5305)
  Revert "MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258)"
  MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258)
  MINOR: bugfix streams total metrics (apache#5277)
  KAFKA-7082: Concurrent create topics may throw NodeExistsException (apache#5259)
  MINOR: Upgrade to Gradle 4.8.1
  KAFKA-7012: Don't process SSL channels without data to process (apache#5237)
  KAFKA-7058: Comparing schema default values using Objects#deepEquals()
  KAFKA-7047: Added SimpleHeaderConverter to plugin isolation whitelist
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrao junrao junrao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajinisivaram @ijuma @junrao