MINOR: Avoid using a big lock in pool#getAndMaybePut #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
reviewed
Jun 20, 2018
| else current | ||
| } | ||
| def getAndMaybePut(key: K, createValue: => V): V = | ||
| pool.computeIfAbsent(key, new java.util.function.Function[K,V] { |
There was a problem hiding this comment.
Oh, this is Scala code and lambdas won't work in Scala 2.11 (but will in Scala 2.12).
There was a problem hiding this comment.
ok, I'll leave it as-is then
ijuma
reviewed
Jun 21, 2018
| } | ||
| def getAndMaybePut(key: K, createValue: => V): V = | ||
| pool.computeIfAbsent(key, new java.util.function.Function[K,V] { | ||
| override def apply(k:K):V = createValue |
There was a problem hiding this comment.
Can you please fix the formatting here? There should be a space after :.
Avoid using a big createLock in pool#getAndMaybePut by using the ConcurrentHashMap#computeIfAbsent function.
cmccabe
force-pushed
the
improve_pool_get_and_maybe_put
branch
from
fb00d8e
to
1dbc5ca
Compare
ijuma
approved these changes
Jun 23, 2018
ijuma
pushed a commit
that referenced
this pull request
Jun 23, 2018
Use `ConcurrentHashMap#computeIfAbsent` which relies on per key locks. Reviewers: Ismael Juma <ismael@juma.me.uk>
ijuma
pushed a commit
that referenced
this pull request
Jun 23, 2018
Use `ConcurrentHashMap#computeIfAbsent` which relies on per key locks. Reviewers: Ismael Juma <ismael@juma.me.uk>
ijuma
added a commit
that referenced
this pull request
Jun 24, 2018
It requires Java 8 and 1.1 still supports Java 7. This reverts commit dc3acb0.
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
Use `ConcurrentHashMap#computeIfAbsent` which relies on per key locks. Reviewers: Ismael Juma <ismael@juma.me.uk>
allenxwang
pushed a commit
to allenxwang/kafka
that referenced
this pull request
Aug 24, 2018
…:1.1.1-sync to 1.1-nflx * commit '9611672e287c1a7933a78590e3f381da2ae7d136': (57 commits) MINOR: increase dev version from 1.1.1-SNAPSHOT to 1.1.2-SNAPSHOT (apache#5409) MINOR: Add thread dumps if broker node cannot be stopped (apache#5373) MINOR: update release.py MINOR: fix upgrade docs for Streams (apache#5392) MINOR: improve docs version numbers (apache#5372) Update version on the branch to 1.1.2-SNAPSHOT KAFKA-6292; Improve FileLogInputStream batch position checks to avoid type overflow (apache#4928) HOTFIX: Fix checkstyle errors in MetricsTest (apache#5345) KAFKA-7136: Avoid deadlocks in synchronized metrics reporters (apache#5341) MINOR: Close timing window in SimpleAclAuthorizer startup (apache#5318) MINOR: Use kill_java_processes when killing ConsoleConsumer in system tests (apache#5297) KAFKA-7104: More consistent leader's state in fetch response (apache#5305) Revert "MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258)" MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258) MINOR: bugfix streams total metrics (apache#5277) KAFKA-7082: Concurrent create topics may throw NodeExistsException (apache#5259) MINOR: Upgrade to Gradle 4.8.1 KAFKA-7012: Don't process SSL channels without data to process (apache#5237) KAFKA-7058: Comparing schema default values using Objects#deepEquals() KAFKA-7047: Added SimpleHeaderConverter to plugin isolation whitelist ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using a big createLock in pool#getAndMaybePut by using the
ConcurrentHashMap#computeIfAbsent function.