KAFKA-7837: Ensure we do not shrink ISR for offline partitions #6202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a partition is marked offline due to a failed disk, the leader is supposed to not shrink its ISR any more. In
ReplicaManager#maybeShrinkIsr
, we iterate through all non-offline partitions to shrink the ISR. If an ISR needs to shrink, we need to write the new ISR to ZK, which can take a bit of time. In this window, some partitions could now be marked as offline, but may not be picked up by the iterator. This is because the offline partition iterator used inReplicaManager#maybeShrinkIsr
is weakly consistent and does not necessarily reflect the updated offline state.This patch fixes the above issue by iterating through all topic partitions and checking whether the partition has been made offline within the iteration. This helps ensure we detect a partition being made offline during the iteration and prevent ISRs from shrinking thereof.