KAFKA-7838: Log leader and follower end offsets when shrinking ISR #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example output from log: |
viktorsomogyi
approved these changes
Jan 22, 2019
| val newInSyncReplicas = inSyncReplicas -- outOfSyncReplicas | ||
| assert(newInSyncReplicas.nonEmpty) | ||
| info("Shrinking ISR from %s to %s".format(inSyncReplicas.map(_.brokerId).mkString(","), | ||
| newInSyncReplicas.map(_.brokerId).mkString(","))) | ||
| debug(s"Leader (hwm: ${leaderReplica.highWatermark.messageOffset}, endOffset: ${leaderReplica.logEndOffset.messageOffset})") |
There was a problem hiding this comment.
nit: I wouldn't use abbreviations such as hwn. I think it's good to call it "highWatermark". It seems nicer.
|
@junrao could you please take a look to see if this looks good. |
junrao
reviewed
Jan 25, 2019
There was a problem hiding this comment.
@dhruvilshah3 : Thanks for the patch. Just one comment below.
| val newInSyncReplicas = inSyncReplicas -- outOfSyncReplicas | ||
| assert(newInSyncReplicas.nonEmpty) | ||
| info("Shrinking ISR from %s to %s".format(inSyncReplicas.map(_.brokerId).mkString(","), | ||
| newInSyncReplicas.map(_.brokerId).mkString(","))) | ||
| debug(s"Leader (highWatermark: ${leaderReplica.highWatermark.messageOffset}, endOffset: ${leaderReplica.logEndOffset.messageOffset})") |
There was a problem hiding this comment.
Could we just include the debug logging as part of the info logging above since it's useful info and doesn't add much additional logging overhead?
junrao
approved these changes
Jan 25, 2019
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* ak/trunk: MINOR: Update usage of deprecated API (apache#6146) KAFKA-4217: Add KStream.flatTransform (apache#5273) MINOR: Update Gradle to 5.1.1 (apache#6160) KAFKA-3522: Generalize Segments (apache#6170) Added quotes around the class path (apache#4469) KAFKA-7837: Ensure offline partitions are picked up as soon as possible when shrinking ISR (apache#6202) MINOR: In the MetadataResponse schema, ignorable should be a boolean KAFKA-7838: Log leader and follower end offsets when shrinking ISR (apache#6168) KAFKA-5692: Change PreferredReplicaLeaderElectionCommand to use Admin… (apache#3848) MINOR: clarify why suppress can sometimes drop tombstones (apache#6195) MINOR: Upgrade ducktape to 0.7.5 (apache#6197) MINOR: Improve IntegrationTestUtils documentation (apache#5664) MINOR: upgrade to jdk8 8u202 KAFKA-7693; Fix SequenceNumber overflow in producer (apache#5989) KAFKA-7692; Fix ProducerStateManager SequenceNumber overflow (apache#5990) MINOR: update copyright year in the NOTICE file. (apache#6196) KAFKA-7793: Improve the Trogdor command line. (apache#6133)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…pache#6168) Reviewers: Jun Rao <junrao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.