-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce github actions for CI #47
Conversation
@sharanf can we please ask infra team to turn on Github Actions for Apache Kibble project? It cannot be configured via The CI seems to be working on my fork: |
@turbaszek I have requested a review from @Humbedooh who is part of the ASF Infra team so if there is anything missing I am sure he will let us know :-) |
f64220b
to
19a9bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! :)
@Humbedooh any update on the possibility of turning on Github Actions for the Apache Kibble project? |
GitHub actions should already be enabled for Kibble |
19a9bc4
to
83b03c8
Compare
Hm, interesting. @Humbedooh do we "Allow all actions" or only "Allow local actions only"? The yaml is ok as the CI is running on my fork: |
Its allow all |
6989159
to
6cb5ae0
Compare
@TobKed you are GA expert, any ideas why GA doesn't want to start? 😄 |
2c206d1
to
062b2ae
Compare
062b2ae
to
e4258e7
Compare
I am not 100% sure but I think it will not run before merging. @Humbedooh is it possible that "Allow local actions only" is overridden by organization settings which may be "Allow all actions"? |
Both org and local setting is "allow all", so I dunno. But we'll see if it'll run once we merge, I guess :) |
Yup, here's reply from Github support:
|
@Humbedooh so it seems we need to merge it to see CI up and running 🤷♂️ This will require a follow-up PR that will make CI green - I can make it asap after merging this |
CONTRIBUTING.md
Outdated
## Code Quality | ||
|
||
Apache Kibble project is using [pre-commits](https://pre-commit.com) to ensure the quality of the code. | ||
We encourage you to use pre-commits, but it's not a required to contribute. Every change is checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be either it's not required in order to contribute
or it's not a requirement in order to contribute
.
Hi all, is there anything that should be done to get this PR merged? @Humbedooh @sharanf |
Hi @turbaszek as @Humbedooh has already given feedback on this I am happy to merge it. |
* Introduce github actions for CI * fixup! Introduce github actions for CI
* Introduce github actions for CI * fixup! Introduce github actions for CI
This is a followup PR for #44