KibbleConfigParser

[skekre98]

I've made KibbleConfigParser a subclass of configparser.ConfigParser. Currently the class is assuming that the ini file has been configured correctly. Let me know if you'd like me to do some error handling if this is not the case.

The usage of this class is as follows:

from configuration import KibbleConfigParser

# Reads kibble.ini by default
conf = KibbleConfigParser()
conf.read("kibble.ini")

for section in conf:
    for key in conf[section]:
            print(conf[section][key])

# Can also be used as follows
# conf.get(section, key)

Output

True
True
2
0.1.0
kibble
elasticsearch
9200
False
localhost
25
Kibble <noreply@kibble.kibble>

I have also created a class variable called uri which is in the format dbname://host:port. Let me know if this is the format you were looking for.

[skekre98]

Apologize for the dirty commit log, took me a second to realize pre-commit was being used 😅

[skekre98]

Not sure why CI error is persisting, working tree is clean even after pre-commit run --all-files. Any suggestions on how to solve?

[turbaszek]

Not sure why CI error is persisting, working tree is clean even after pre-commit run --all-files. Any suggestions on how to solve?

Have you done git add after running pre-commit?

[skekre98]

Not sure why CI error is persisting, working tree is clean even after pre-commit run --all-files. Any suggestions on how to solve?

Have you done git add after running pre-commit?

Yes, I run the commands as follows:

$ pre-commit run --all-files
$ git add .
$ git commit -m "msg"
$ git push origin master

This is the output of the pre-commit command:

(home) Sharvils-MacBook-Pro:kibble sharvilkekre$ pre-commit run --all-files
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Fix python encoding pragma...............................................Passed
Add license for all other files..........................................Passed
Add license for all rst files............................................Passed
Add license for all md and html files................(no files to check)Skipped

Am I missing something?

[turbaszek]

@skekre98 please rebase, you are missing last changes from #66

git remote add apache git@github.com:apache/kibble.git
git fetch --all
git rebase apache/master
git push --force

[skekre98]

I apologize for the delay. Still getting used to the repo workflow 😅. Let me know if there is anything I left out.

[turbaszek]

@skekre98 would you mind refactoring kibble/setup/setup.py so it uses this config for default values?

[skekre98]

@skekre98 would you mind refactoring kibble/setup/setup.py so it uses this config for default values?

Could you elaborate on this a bit? Are you looking for me to refactor get_parser and return an instance of KibbleConfigParser?

[turbaszek]

@skekre98 would you mind refactoring kibble/setup/setup.py so it uses this config for default values?

Could you elaborate on this a bit? Are you looking for me to refactor get_parser and return an instance of KibbleConfigParser?

Once we have configuration file for Kibble we should use it in the application:

1. create instance of Kibble config config = KibbleConfigParser()
2. use it as config.get("section", "key") for default values in https://github.com/apache/kibble/blob/d7f9031dfd93a2efd676fcbd59443feec01df6ed/kibble/setup/setup.py#L43-L54

This will also required some refactor of the setup script + docker-compose to be sure it works.

Let me know if you would like to try do this or should we merge this PR as it is.

[skekre98]

Should we perhaps merge this, and address setup.py in a different issue? I feel like this may require a bit more understanding from my end which we could discuss on the other issue. I will likely have some elaboration questions when I begin working on it as well ☺️.