Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-1994 - Update Ranger API service definition to allow separate URL patterns #136

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

vishalsuvagia
Copy link
Contributor

@vishalsuvagia vishalsuvagia commented Aug 26, 2019

What changes were proposed in this pull request?

Currently Ranger service and plugin endpoints are exposed via Knox. The endpoints should allow url query params too.

@vishalsuvagia
Copy link
Contributor Author

@risdenk / @lmccay request to kindly review the patch

@risdenk risdenk self-assigned this Aug 26, 2019
@risdenk risdenk self-requested a review August 26, 2019 20:55
@risdenk
Copy link
Contributor

risdenk commented Aug 26, 2019

@vishalsuvagia - I edited the PR to have unique rule names. Looks like this was missed on the previous PR. Also kicked off the Travis CI build to check the change. If it builds, I'll merge.

@risdenk risdenk changed the title KNOX-1994 : Update Ranger API service definition to allow separate UR… KNOX-1994 : Update Ranger API service definition to allow separate URL patterns Aug 26, 2019
@risdenk risdenk merged commit a6197d1 into apache:master Aug 26, 2019
@risdenk risdenk changed the title KNOX-1994 : Update Ranger API service definition to allow separate URL patterns KNOX-1994 - Update Ranger API service definition to allow separate URL patterns Aug 26, 2019
@vishalsuvagia
Copy link
Contributor Author

Thank-you @risdenk for reviewing and merging the patch.

twmarshall pushed a commit to twmarshall/knox that referenced this pull request Aug 27, 2019
… separate URL patterns (apache#136)

Signed-off-by: Kevin Risden <krisden@cloudera.com>
Change-Id: I9e9980bf81dfb836706a19cad5d8a0ce5e2920f7
twmarshall pushed a commit to twmarshall/knox that referenced this pull request Aug 27, 2019
…o allow separate URL patterns (apache#136)" into cdpd-master
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
… separate URL patterns (apache#136)

Signed-off-by: Kevin Risden <krisden@cloudera.com>
Change-Id: I9e9980bf81dfb836706a19cad5d8a0ce5e2920f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants