Extract a rand sample helper and support negative sample count in "Set" #2113
Conversation
mapleFU
changed the title
mapleFU
force-pushed
the
cmd-srand-support-negative
branch
from
f07c2ea
to
9a3e127
Compare
There was a problem hiding this comment.
LGTM.
I just wondering whether @PragmaTwice will advise to rename sample_helper.h to something with _util.h suffix like random_util/random_sample_util/sample_util :)
mapleFU
force-pushed
the
cmd-srand-support-negative
branch
from
dd87b99
to
6c22327
Compare
| batch->Put(metadata_cf_handle_, ns_key, bytes); | ||
| // Avoid to write an empty op-log if just random select some members. | ||
| if (!pop) return rocksdb::Status::OK(); | ||
| // Avoid to write an empty op-log if the set is empty. |
There was a problem hiding this comment.
Don't know whether we can do this optimization, would it affect replication?
| if (!s.ok()) { | ||
| return s; | ||
| } | ||
| switch (type) { |
There was a problem hiding this comment.
This is just a dcheck. Previously, code called with append_field_with_index. However, GetAll is already called with "type", so it's not neccessary to clean up or set it again
|
I am fine since this file is not in common dir. |
This patch: