Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SelectExpr to SelectClause to prevent misunderstanding #2239

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

PragmaTwice
Copy link
Member

SelectExpr is not an appropriate name since it can represent the whole select .. from .. expression.

mapleFU
mapleFU previously approved these changes Apr 11, 2024
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this, expr should be simplier, select should be clause/node/operator...

torwig
torwig previously approved these changes Apr 11, 2024
@PragmaTwice PragmaTwice dismissed stale reviews from torwig and mapleFU via 6176c20 April 11, 2024 14:47
Copy link

sonarcloud bot commented Apr 11, 2024

@PragmaTwice PragmaTwice merged commit ab3a61d into apache:unstable Apr 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants