Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cube count column for project table #1277

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Add cube count column for project table #1277

merged 1 commit into from
Aug 22, 2020

Conversation

MorningLight5
Copy link

Proposed changes

Add cube count column for project table for convience.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6048

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.002%) to 27.975%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 6043: -0.002%
Covered Lines: 26109
Relevant Lines: 93331

💛 - Coveralls

@shaofengshi shaofengshi self-requested a review August 22, 2020 01:57
@shaofengshi shaofengshi merged commit 0b9456c into apache:master Aug 22, 2020
@shaofengshi
Copy link
Contributor

Hi Tianhui, the code looks good; Next time, please provide the JIRA ID in the PR description, and the GIT commit message; I searched it in JIRA for a while, and then manually added that this time, hope next time it can be prepared well from begining. Thank you!

@MorningLight5
Copy link
Author

Hi Tianhui, the code looks good; Next time, please provide the JIRA ID in the PR description, and the GIT commit message; I searched it in JIRA for a while, and then manually added that this time, hope next time it can be prepared well from begining. Thank you!

My apologizes. Thanks for your kindness.

hit-lacus pushed a commit to hit-lacus/kylin that referenced this pull request Oct 8, 2020
Co-authored-by: tianhui5 <tianhui5@xiaomi.com>
hit-lacus pushed a commit that referenced this pull request Oct 12, 2020
Co-authored-by: tianhui5 <tianhui5@xiaomi.com>
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
Co-authored-by: tianhui5 <tianhui5@xiaomi.com>
(cherry picked from commit 0b9456c)
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
Co-authored-by: tianhui5 <tianhui5@xiaomi.com>
(cherry picked from commit 0b9456c)
hit-lacus pushed a commit that referenced this pull request Jun 27, 2021
Co-authored-by: tianhui5 <tianhui5@xiaomi.com>
(cherry picked from commit 0b9456c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants