Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor, fix sonar reported bugs #1368

Merged
merged 3 commits into from
Aug 23, 2020
Merged

Conversation

shaofengshi
Copy link
Contributor

Proposed changes

Another batch of fix for sonar reported code bugs

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

Codecov Report

Merging #1368 into master will increase coverage by 0.01%.
The diff coverage is 17.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1368      +/-   ##
============================================
+ Coverage     25.46%   25.47%   +0.01%     
- Complexity     6732     6759      +27     
============================================
  Files          1505     1506       +1     
  Lines         93319    93650     +331     
  Branches      13085    13121      +36     
============================================
+ Hits          23764    23859      +95     
- Misses        67216    67413     +197     
- Partials       2339     2378      +39     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/common/KylinConfigBase.java 12.56% <0.00%> (-0.13%) 51.00 <0.00> (ø)
...rg/apache/kylin/common/kafka/KafkaMsgProducer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../org/apache/kylin/common/livy/LivyRestBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...org/apache/kylin/common/livy/LivyRestExecutor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ylin/common/metrics/perflog/PerfLoggerFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/kylin/common/persistence/JDBCResourceStore.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lin/common/persistence/ResourceParallelCopier.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../apache/kylin/common/persistence/ResourceTool.java 21.22% <0.00%> (ø) 14.00 <0.00> (ø)
...org/apache/kylin/common/restclient/RestClient.java 17.79% <0.00%> (+2.54%) 8.00 <0.00> (+2.00)
.../main/java/org/apache/kylin/common/util/Array.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfbb724...af28bd5. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 20, 2020

Pull Request Test Coverage Report for Build 6273

  • 38 of 119 (31.93%) changed or added relevant lines in 24 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.005%) to 28.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/RowRecordReader.java 12 13 92.31%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/FSInputGeneralColumnDataReader.java 0 1 0.0%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/FragmentCuboidReader.java 2 3 66.67%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/SegmentMemoryStore.java 6 7 85.71%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/FSInputRLECompressedColumnReader.java 3 4 75.0%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/LZ4CompressedColumnReader.java 1 2 50.0%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/NoCompressedColumnReader.java 1 2 50.0%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/RunLengthCompressedColumnReader.java 1 2 50.0%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 1 2 50.0%
core-cube/src/main/java/org/apache/kylin/gridtable/GTTwoLayerAggregateScanner.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java 1 0%
core-cube/src/main/java/org/apache/kylin/gridtable/GTTwoLayerAggregateScanner.java 1 0%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 1 81.58%
core-cube/src/main/java/org/apache/kylin/gridtable/GTAggregateTransformScanner.java 4 0%
Totals Coverage Status
Change from base Build 6269: 0.005%
Covered Lines: 26254
Relevant Lines: 93651

💛 - Coveralls

@hit-lacus
Copy link
Member

LGTM

@hit-lacus hit-lacus merged commit 0b936eb into apache:master Aug 23, 2020
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
* minor, fix sonar reported bugs

* minor, fix sonar

* minor, code format

(cherry picked from commit 0b936eb)
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
* minor, fix sonar reported bugs

* minor, fix sonar

* minor, code format

(cherry picked from commit 0b936eb)
hit-lacus pushed a commit that referenced this pull request Jun 27, 2021
* minor, fix sonar reported bugs

* minor, fix sonar

* minor, code format

(cherry picked from commit 0b936eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants