-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor, fix sonar reported bugs #1368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
============================================
+ Coverage 25.46% 25.47% +0.01%
- Complexity 6732 6759 +27
============================================
Files 1505 1506 +1
Lines 93319 93650 +331
Branches 13085 13121 +36
============================================
+ Hits 23764 23859 +95
- Misses 67216 67413 +197
- Partials 2339 2378 +39
Continue to review full report at Codecov.
|
LGTM |
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
* minor, fix sonar reported bugs * minor, fix sonar * minor, code format (cherry picked from commit 0b936eb)
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
* minor, fix sonar reported bugs * minor, fix sonar * minor, code format (cherry picked from commit 0b936eb)
hit-lacus
pushed a commit
that referenced
this pull request
Jun 27, 2021
* minor, fix sonar reported bugs * minor, fix sonar * minor, code format (cherry picked from commit 0b936eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Another batch of fix for sonar reported code bugs
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...