-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly #1529
Conversation
… havingFilter correctly
2d5f39f
to
f8d1f1d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
============================================
- Coverage 25.51% 25.44% -0.08%
+ Complexity 6765 6762 -3
============================================
Files 1505 1507 +2
Lines 93632 93828 +196
Branches 13117 13145 +28
============================================
- Hits 23886 23870 -16
- Misses 67370 67577 +207
- Partials 2376 2381 +5
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 6699
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Verified passed. LGTM. Before this pr:'OPS_USER_ID' is shard by column.
After this pr:The sql shown above are executed successfully. |
LGTM |
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases (cherry picked from commit 92e8d75)
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases (cherry picked from commit 92e8d75)
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases (cherry picked from commit 92e8d75)
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases (cherry picked from commit 92e8d75)
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases (cherry picked from commit 92e8d75)
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases (cherry picked from commit 92e8d75)
… havingFilter correctly (apache#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases
… havingFilter correctly (#1529) * KYLIN-4682 Fix java.lang.IndexOutOfBoundsException due to not setting havingFilter correctly * KYLIN-4682 Add test cases
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...