-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYLIN-4667] Automatically set kylin.query.cache-signature-enabled to… #1540
Conversation
… be true when memcached is enabled
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
============================================
- Coverage 25.42% 25.41% -0.02%
+ Complexity 6764 6762 -2
============================================
Files 1508 1508
Lines 93918 93923 +5
Branches 13158 13159 +1
============================================
- Hits 23879 23867 -12
- Misses 67660 67673 +13
- Partials 2379 2383 +4
Continue to review full report at Codecov.
|
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.beans.factory.annotation.Qualifier; | ||
import org.springframework.stereotype.Component; | ||
|
||
import net.sf.ehcache.CacheManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why chenge to another org.springframework.cache.CacheManager.CacheManager
, could you please explain ?
…e true when memcached is enabled (apache#1540)
…e true when memcached is enabled (apache#1540) (cherry picked from commit 49d7b9b)
…e true when memcached is enabled (apache#1540) (cherry picked from commit 49d7b9b)
…e true when memcached is enabled (#1540)
… be true when memcached is enabled
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...