[KYLIN-4667] Automatically set kylin.query.cache-signature-enabled to… #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be true when memcached is enabled
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
============================================
- Coverage 25.42% 25.41% -0.02%
+ Complexity 6764 6762 -2
============================================
Files 1508 1508
Lines 93918 93923 +5
Branches 13158 13159 +1
============================================
- Hits 23879 23867 -12
- Misses 67660 67673 +13
- Partials 2379 2383 +4
Continue to review full report at Codecov.
|
hit-lacus
reviewed
Feb 7, 2021
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.beans.factory.annotation.Qualifier; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| import net.sf.ehcache.CacheManager; |
There was a problem hiding this comment.
I don't understand why chenge to another org.springframework.cache.CacheManager.CacheManager, could you please explain ?
hit-lacus
pushed a commit
to hit-lacus/kylin
that referenced
this pull request
Apr 19, 2021
…e true when memcached is enabled (apache#1540)
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
…e true when memcached is enabled (apache#1540) (cherry picked from commit 49d7b9b)
zhangayqian
pushed a commit
to zhangayqian/kylin
that referenced
this pull request
Jun 11, 2021
…e true when memcached is enabled (apache#1540) (cherry picked from commit 49d7b9b)
zhangayqian
pushed a commit
that referenced
this pull request
Nov 5, 2021
…e true when memcached is enabled (#1540)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… be true when memcached is enabled
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...