Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4930 reset current page when searching for users/groups #1607

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

xiacongling
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

The bug is caused by the current page not being reset, and it may exceeds the total number of pages of the search result.

@codecov-io
Copy link

Codecov Report

Merging #1607 (1b37ddc) into master (0250081) will decrease coverage by 0.00%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1607      +/-   ##
============================================
- Coverage     25.42%   25.41%   -0.01%     
+ Complexity     6765     6763       -2     
============================================
  Files          1508     1508              
  Lines         93918    93923       +5     
  Branches      13158    13160       +2     
============================================
- Hits          23877    23870       -7     
- Misses        67662    67670       +8     
- Partials       2379     2383       +4     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/common/KylinConfigBase.java 12.46% <0.00%> (ø) 51.00 <0.00> (ø)
...che/kylin/storage/gtrecord/CubeTupleConverter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/kylin/rest/controller/StreamingV2Controller.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apache/kylin/storage/hbase/HBaseResourceStore.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lin/stream/core/query/StreamingTupleConverter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lin/stream/source/kafka/TimedJsonStreamParser.java 67.39% <0.00%> (ø) 12.00 <0.00> (ø)
...stream/core/query/MultiThreadsResultCollector.java 63.91% <66.66%> (+0.37%) 4.00 <0.00> (ø)
.../apache/kylin/tool/query/ProbabilityGenerator.java 65.78% <0.00%> (-10.53%) 10.00% <0.00%> (-1.00%)
...va/org/apache/kylin/tool/query/QueryGenerator.java 80.00% <0.00%> (-1.12%) 23.00% <0.00%> (-1.00%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.30% <0.00%> (-0.92%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3f114...1b37ddc. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6955

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 27.956%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 6948: 0.0%
Covered Lines: 26257
Relevant Lines: 93923

💛 - Coveralls

@hit-lacus hit-lacus merged commit d6073d2 into apache:master Mar 18, 2021
hit-lacus pushed a commit to hit-lacus/kylin that referenced this pull request Apr 19, 2021
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Jun 11, 2021
hit-lacus pushed a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kylin 3.X Kylin 3.X
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants