-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4930 reset current page when searching for users/groups #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1607 +/- ##
============================================
- Coverage 25.42% 25.41% -0.01%
+ Complexity 6765 6763 -2
============================================
Files 1508 1508
Lines 93918 93923 +5
Branches 13158 13160 +2
============================================
- Hits 23877 23870 -7
- Misses 67662 67670 +8
- Partials 2379 2383 +4
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 6955
💛 - Coveralls |
hit-lacus
pushed a commit
to hit-lacus/kylin
that referenced
this pull request
Apr 19, 2021
hit-lacus
pushed a commit
that referenced
this pull request
Jun 27, 2021
(cherry picked from commit d6073d2)
zhangayqian
pushed a commit
that referenced
this pull request
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
The bug is caused by the current page not being reset, and it may exceeds the total number of pages of the search result.