Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4028 Speed up startup progress using cached dependency #672

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

TempleZhou
Copy link
Member

No description provided.

@asfgit
Copy link

asfgit commented Jun 3, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #672 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #672      +/-   ##
============================================
- Coverage      25.8%   25.78%   -0.02%     
+ Complexity     6011     6008       -3     
============================================
  Files          1382     1382              
  Lines         82194    82194              
  Branches      11516    11516              
============================================
- Hits          21208    21195      -13     
- Misses        58942    58951       +9     
- Partials       2044     2048       +4
Impacted Files Coverage Δ Complexity Δ
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...che/kylin/stream/core/storage/CheckPointStore.java 63.63% <0%> (-3.04%) 21% <0%> (-1%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-1.52%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ed8b2...37bfe8b. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4572

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 28.282%

Files with Coverage Reduction New Missed Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
Totals Coverage Status
Change from base Build 4569: 0.0%
Covered Lines: 23246
Relevant Lines: 82194

💛 - Coveralls

@nichunen
Copy link

Tested, works fine.

@nichunen nichunen merged commit 807a571 into apache:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants