Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "#KYLIN-4044, upgrade curator dependency version" #703

Closed
wants to merge 1 commit into from

Conversation

hit-lacus
Copy link
Member

@hit-lacus hit-lacus commented Jun 20, 2019

This reverts commit 9708990.
Because this commit cause mvn compile error.

@asfgit
Copy link

asfgit commented Jun 20, 2019

Can one of the admins verify this patch?

2 similar comments
@asfgit
Copy link

asfgit commented Jun 20, 2019

Can one of the admins verify this patch?

@asfgit
Copy link

asfgit commented Jun 20, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #703 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #703      +/-   ##
============================================
- Coverage     25.74%   25.72%   -0.02%     
+ Complexity     6014     6012       -2     
============================================
  Files          1385     1385              
  Lines         82424    82424              
  Branches      11557    11557              
============================================
- Hits          21216    21207       -9     
- Misses        59167    59173       +6     
- Partials       2041     2044       +3
Impacted Files Coverage Δ Complexity Δ
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9708990...958a3e8. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4635

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 28.213%

Files with Coverage Reduction New Missed Lines %
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 4 77.81%
Totals Coverage Status
Change from base Build 4633: 0.007%
Covered Lines: 23254
Relevant Lines: 82424

💛 - Coveralls

@hit-lacus hit-lacus closed this Jun 24, 2019
@hit-lacus hit-lacus deleted the revert-curator branch August 16, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants